-
Notifications
You must be signed in to change notification settings - Fork 225
[config] new env var: REQUIRE_APPROVAL_NEW_MEMBERS to set requiring…
#858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] new env var: REQUIRE_APPROVAL_NEW_MEMBERS to set requiring…
#858
Conversation
… approval via config vs. UI toggle only
|
Caution Review failedThe pull request is closed. WalkthroughAdds a REQUIRE_APPROVAL_NEW_MEMBERS environment variable and server schema entry, synchronizes single-tenant org member-approval on init when set, disables the UI toggle and shows an informational message when the env var controls the setting, and updates docs and changelog. Changes
Sequence Diagram(s)mermaid mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Around line 8-9: The changelog entry for "Added support to set 'Require
approval for new members' via config (`REQUIRE_APPROVAL_NEW_MEMBERS`)" is
missing a category header; move or insert this bullet under the existing "###
Added" subsection within the Unreleased section so it follows the project's
changelog conventions (use the exact header text "### Added" and keep the
current bullet content intact).
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
REQUIRE_APPROVAL_NEW_MEMBERSso that this can be set via config vs. UI toggle on each upgrade/deployment.Summary by CodeRabbit
New Features
Documentation